[kustomize_deploy] Improve code clarity #3468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
evallesp
approved these changes
Nov 10, 2025
michburk
approved these changes
Nov 10, 2025
rebtoor
approved these changes
Nov 12, 2025
holser
force-pushed
the
fix_subscription_installation
branch
from
441a0e2 to
87481ef
Compare
holser
force-pushed
the
fix_subscription_installation
branch
from
87481ef to
4f7a974
Compare
holser
force-pushed
the
fix_subscription_installation
branch
from
4f7a974 to
ab0393a
Compare
holser
force-pushed
the
fix_subscription_installation
branch
from
ab0393a to
7ce520b
Compare
holser
changed the title
- Rename _cifmw_kustomize_deploy_olm_osp_operator_sub to _cifmw_kustomize_deploy_olm_osp_operator_subscription for better readability and consistency. - Add dedicated cifmw_kustomize_deploy_retries_subscription parameter (default: 90) to allow independent configuration of Subscription vs InstallPlan retry timeouts. - Fix task name from 'Wait for InstallPlan to be created' to 'Wait for Subscription to be created' to correctly reflect what the task is actually waiting for. - Update role README.md to document the new retries_subscription parameter in the Timeouts section. This change improves maintainability by using more descriptive variable names and properly separating concerns between Subscription and InstallPlan wait operations. Resolves: https://issues.redhat.com/browse/OSPCIX-1100 Assisted-By: Claude Code/claude-sonnet-4.5 Signed-off-by: Sergii Golovatiuk <[email protected]>
holser
force-pushed
the
fix_subscription_installation
branch
from
7ce520b to
02022a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[kustomize_deploy] Improve code clarity
Rename _cifmw_kustomize_deploy_olm_osp_operator_sub to
_cifmw_kustomize_deploy_olm_osp_operator_subscription for better
readability and consistency.
Add dedicated cifmw_kustomize_deploy_retries_subscription parameter
(default: 90) to allow independent configuration of Subscription vs
InstallPlan retry timeouts.
Fix task name from 'Wait for InstallPlan to be created' to
'Wait for Subscription to be created' to correctly reflect what
the task is actually waiting for.
Update role README.md to document the new retries_subscription
parameter in the Timeouts section.
This change improves maintainability by using more descriptive variable
names and properly separating concerns between Subscription and
InstallPlan wait operations.
Resolves: https://issues.redhat.com/browse/OSPCIX-1100
Assisted-By: Claude Code/claude-sonnet-4.5
Signed-off-by: Sergii Golovatiuk [email protected]